Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for custom titles. #18

Merged
merged 5 commits into from
Jun 9, 2022

Conversation

DameonSmith
Copy link
Contributor

I wanted the ability to add a custom header to the issue to provide additional context. Something like what I wanted to have were "Deploying version x.x.x to staging from dev". I attempted to simply make it a subtitle to the current format to not lose existing information, and to simplify the logic.

I made sure all the tests passed and tried to remain stylistically consistent. This is my first time messing around with a github action, so there may be something that I missed. The docker version is something that I didn't update which would probably mess things up as it stands.

Let me know if you like this idea, and if you need me to make any edits.

Copy link
Owner

@trstringer trstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! Thank you for opening this PR. Just a few small changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yaml Outdated Show resolved Hide resolved
constants.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Copy link
Owner

@trstringer trstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small changes. This looks great!

README.md Outdated Show resolved Hide resolved
action.yaml Outdated Show resolved Hide resolved
DameonSmith and others added 2 commits June 8, 2022 20:10
Co-authored-by: Thomas Stringer <thomas@trstringer.com>
Co-authored-by: Thomas Stringer <thomas@trstringer.com>
@DameonSmith
Copy link
Contributor Author

Removed those periods. 👍

Copy link
Owner

@trstringer trstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you so much for your contribution. This will make it into the next release, which I expect to create in the next day or two.

@trstringer trstringer merged commit 3ecbcf2 into trstringer:main Jun 9, 2022
@DameonSmith
Copy link
Contributor Author

You're welcome! Looking forward to the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants