-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for custom titles. #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great! Thank you for opening this PR. Just a few small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small changes. This looks great!
Co-authored-by: Thomas Stringer <thomas@trstringer.com>
Co-authored-by: Thomas Stringer <thomas@trstringer.com>
Removed those periods. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you so much for your contribution. This will make it into the next release, which I expect to create in the next day or two.
You're welcome! Looking forward to the next release :) |
I wanted the ability to add a custom header to the issue to provide additional context. Something like what I wanted to have were "Deploying version x.x.x to staging from dev". I attempted to simply make it a subtitle to the current format to not lose existing information, and to simplify the logic.
I made sure all the tests passed and tried to remain stylistically consistent. This is my first time messing around with a github action, so there may be something that I missed. The docker version is something that I didn't update which would probably mess things up as it stands.
Let me know if you like this idea, and if you need me to make any edits.