Set minimum approvals #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trstringer
requested changes
Mar 28, 2022
added 4 commits
March 29, 2022 22:03
|
Hi @trstringer , I have made the changes you have requested |
|
Love the feature, please merge it to make it available for general use :) |
|
this be great, waiting for merge ! |
|
Thank you for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting a minimum number of approvals before the workflow continues, via a new input parameter
minimum_approvals.This means you can now list an entire team of users as
approvers, but only need one of them to approve the manual step.If the new parameter is not set, the existing behaviour is preserved - all reviewers are required to approve.
I have updated the test suite to take this change into account, and I compiled my own docker image to test in a separate repository.
Passing workflow: https://github.com/elmundio87/manual-approval-test/runs/5706511606?check_suite_focus=true
Associated issue: elmundio87/manual-approval-test#5
Thanks for the great Github Action!