Unable to Expand Org Team

[gthomson31]

Hi There

Currently utilising this action within a new pipeline and have ran into the following issue.
This works when using individual org users but not team names.

      - name: Generate Approval token
        id: generate_token
        uses: tibdex/github-app-token@v1
        with:
          app_id: ${{ secrets.GLOBAL_WORKFLOW_APPROVAL_APP_ID }}
          private_key: ${{ secrets.GLOBAL_WORKFLOW_APPROVAL_APP_PRIVATE_KEY }}

      - name: Wait for execution approval
        id: procceed-with-execution-of-aws-sandbox-nuke
        uses: trstringer/manual-approval@v1
        with:
          secret: ${{ steps.generate_token.outputs.token }}
          approvers: ${{ env.GITHUB_TEAM_NAME }}
          minimum-approvals: 1
          issue-title: "${{ github.action }}" # optional - default is "Manual Approval"

Attempting to expand user snowplow-devops/com.snowplowanalytics.engineeringproductivity as a group (may not succeed)
GET https://api.github.com/orgs/snowplow-devops/teams/com.snowplowanalytics.engineeringproductivity/members: 404 Not Found []
Creating issue in repo snowplow-devops/engineering-productivity with the following content:
Title: Manual approval required for workflow run 3368332814: procceed-with-execution-of-aws-sandbox-nuke

Any help appreciated!

[trstringer]

Hmm that's really interesting. Can you use the GitHub CLI and make the following request?

$ gh api -H "Accept: application/vnd.github+json" /orgs/snowplow-devops/teams/com.snowplowanalytics.engineeringproductivity/members

Does that succeed, or do you get a 404 from that as well?

[kdesao-devops]

Hey +1 !
It appears that this block doesn't work anymore for my app either :/.

Hmm that's really interesting. Can you use the GitHub CLI and make the following request?

$ gh api -H "Accept: application/vnd.github+json" /orgs/snowplow-devops/teams/com.snowplowanalytics.engineeringproductivity/members

Does that succeed, or do you get a 404 from that as well?

I've changed to match my config and I have the same 404 that my Github action failed on.
Probably an update on the GitHub API ?

[gthomson31]

Hey ,

So I have cracked the issue its down to how Github handles certain characters in names

When you have a team name containing "." these are replaced with "-" in the team name Slug

"name": "com.snowplowanalytics.engineeringproductivity",
"slug": "com-snowplowanalytics-engineeringproductivity",

by updating the team name slug to show the following the issue is now resolved

      - name: Wait for execution approval
        id: procceed-with-execution-of-sandbox-nuke
        uses: trstringer/manual-approval@v1
        with:
          secret: ${{ steps.generate_token.outputs.token }}
          approvers: com-snowplowanalytics-engineeringproductivity
          minimum-approvals: 1
          issue-title: "${{ github.action }}" # optional - default is "Manual Approval"

[gthomson31]

Works perfect now just went through a test run 👍🏻

[trstringer]

Wow that's really interesting, I didn't know that. I'm going to reopen this, I think this behavior isn't intuitive so this action should handle this without the user having to know this behavior.