server: rewrite package comments in English #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandyskies
reviewed
Oct 17, 2023
server/server.go
Outdated
| @@ -3,7 +3,8 @@ | |||
| // If you have downloaded a copy of the tRPC source code from Tencent, | |||
| // please note that tRPC source code is licensed under the Apache 2.0 License that can be found in the LICENSE file. | |||
|
|
|||
| // Package server 服务端，包括网络通信 名字服务 监控统计 链路跟踪等各个组件基础接口，具体实现由第三方 middleware 注册进来 | |||
| // Package server provides a framework for managing multiple services within a single process. | |||
| // A server process may listen on multiple ports, providing different business services on different ports. | |||
There was a problem hiding this comment.
Don't mention business at all.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 85.59% 85.63% +0.04%
==========================================
Files 188 188
Lines 16114 16114
==========================================
+ Hits 13793 13800 +7
+ Misses 1760 1756 -4
+ Partials 561 558 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
and fix CONTRIBUTING.zh_CN.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.