Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: remove main.go client_test.go and custom.yaml under example/features/feature/xxx dir #135

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

liuzengh
Copy link
Contributor

@liuzengh liuzengh commented Nov 9, 2023

under example/features/feature/xxx dir

under example/features/feature/xxx dir
@liuzengh
Copy link
Contributor Author

liuzengh commented Nov 9, 2023

feedback from internal users in the company.

@liuzengh liuzengh changed the title examples: remove main.go client_test.go and custom.yaml examples: remove main.go client_test.go and custom.yaml under example/features/feature/xxx dir Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37d2008) 85.49277% compared to head (b3116b9) 85.66024%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #135         +/-   ##
===================================================
+ Coverage   85.49277%   85.66024%   +0.16747%     
===================================================
  Files            189         189                 
  Lines          16123       16123                 
===================================================
+ Hits           13784       13811         +27     
+ Misses          1778        1751         -27     
  Partials         561         561                 
Flag Coverage Δ
unittests 85.66024% <ø> (+0.16747%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyskies sandyskies merged commit cf5ca25 into trpc-group:main Nov 10, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants