Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: import renaming("gopkg.in/yaml.v3" => yaml "gopkg.in/yaml.v3") #112

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

liuzengh
Copy link
Contributor

No description provided.

@liuzengh liuzengh requested a review from sandyskies October 18, 2023 09:47
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (da34248) 85.77% compared to head (47f6b0f) 85.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   85.77%   85.75%   -0.02%     
==========================================
  Files         188      188              
  Lines       16114    16114              
==========================================
- Hits        13821    13819       -2     
- Misses       1734     1736       +2     
  Partials      559      559              
Flag Coverage Δ
unittests 85.75% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
config.go 80.09% <ø> (ø)
config/trpc_config.go 84.45% <ø> (ø)
log/config.go 100.00% <ø> (ø)
plugin/setup.go 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuzengh liuzengh requested a review from WineChord October 19, 2023 02:38
Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WineChord
Copy link
Contributor

WineChord commented Oct 19, 2023

I came across this information regarding codecov:

https://docs.codecov.com/docs/commit-status#threshold

image

It appears that we need to incorporate this into https://app.codecov.io/account/gh/trpc-group/yaml/

image

I attempted to do so yesterday, but it didn't function as anticipated.

@sandyskies sandyskies merged commit 64c8a7b into trpc-group:main Oct 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants