Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: upgrade golang.org/x/net to latest version #106

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

WineChord
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dff87b7) 85.66% compared to head (4c8a0c4) 85.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   85.66%   85.63%   -0.04%     
==========================================
  Files         188      188              
  Lines       16114    16114              
==========================================
- Hits        13804    13799       -5     
- Misses       1747     1754       +7     
+ Partials      563      561       -2     
Flag Coverage Δ
unittests 85.63% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WineChord
Copy link
Contributor Author

Why has the code coverage decreased when I have only made changes to go.mod and go.sum files? 🙁

@sandyskies
Copy link
Contributor

@WineChord
Copy link
Contributor Author

I suspect that there might be a degree of randomization in the test cases, which could occasionally lead to variations in code coverage. For instance, in #113, despite only making changes to the markdown files, there was still a slight decrease in code coverage.

Copy link
Contributor

@liuzengh liuzengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyskies sandyskies merged commit f87377f into trpc-group:main Oct 19, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants