Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

NPM cache: migrate ddb to s3 #3

Merged
merged 16 commits into from
Apr 30, 2020

Conversation

edgarpoce
Copy link
Contributor

@edgarpoce edgarpoce commented Apr 30, 2020

Goal
migrate npm cache registry entry from ddb to s3

Implementation

  • removed ddb table
  • now the same bucket is used to store both the registry entry and the version tarballs. index is stored under the library folder with index.gz as the file name. There shouldn't be any collision because tarballs are stored with .tgz as the extension.
  • refactored lambdas in the scope of this work with a more object oriented design
  • added unit tests
  • added seamless migration support. when autoupdate is executed the registry entry is stored in s3.

@edgarpoce edgarpoce marked this pull request as draft April 30, 2020 05:00
@edgarpoce edgarpoce marked this pull request as ready for review April 30, 2020 13:59
Copy link
Owner

@troyready troyready left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. Added my nitpicky thoughts inline.

.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/npm/NpmPackage.test.ts Outdated Show resolved Hide resolved
src/npm/NpmPackage.ts Show resolved Hide resolved
src/npm/autoupdate/autoupdate.ts Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
src/npm/NpmPackage.ts Outdated Show resolved Hide resolved
jest.config.js Outdated Show resolved Hide resolved
src/npm/package/package.ts Outdated Show resolved Hide resolved
@troyready
Copy link
Owner

@edgarpoce I neglected to include this in my last review as well: some of the top-level README needs to be updated to reflect these changes

@edgarpoce
Copy link
Contributor Author

@edgarpoce I neglected to include this in my last review as well: some of the top-level README needs to be updated to reflect these changes

fixed in d5e4c96

@troyready troyready merged commit 8b491a0 into troyready:master Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants