-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenXLSX does not do garbage collection in sharedStrings.xml #193
Comments
This is an unfortunate consequence of the complex indexing that Excel does across worksheets - shared strings have no explicit index, they are referred by cells only by their position inside the shared strings xml array. This means every time a shared string would be deleted, the whole workbook would require re-indexing. This could possibly be addressed in a future patch by a function "cleanupSharedStrings" or something like that, which does the reindexing once, on the users request, and letting the user control when the computation overhead happens. I'll keep this open for now but can't promise a quick implementation :) |
…Iterator no longer creates missing rows unless iterator is dereferenced
Guess what :) 4589a6c |
Functionality is now merged into master. |
When overwriting a string in a cell with a new, unique string, the new string is simply appended to the end of the table in
sharedStrings.xml
without the old string getting removed fromsharedStrings.xml
in case it's no longer used.The text was updated successfully, but these errors were encountered: