Mark service dirty if the command line args have changed

[JackNewman12]

This fixes initctl reload correctly restarting all daemons that have new command line arguments.
Previously command line arguments changes were only acted upon if the service was explicitly reloaded using initctl reload myservice since it blindly sets the svc->dirty flag.

When checking if a service should be restarted, svc_is_changed() checks for the svc->dirty flag, and then only after that will svc_sighup() look for the svc->args_dirty flag. Hence a difference in command line arguments would not result in a service being restarted.

finit/src/service.c

Lines 2289 to 2293 in 9887003

	case COND_ON:
	if (svc_is_changed(svc)) {
	if (svc_nohup(svc))
	service_stop(svc);
	else {

You could also add the || svc->args_dirty check into the svc_is_changed(), but I think it makes sense this way.

[troglobit]

Nice catch, thanks!

Dunno why one of the tests fail. Running the same patch on my local system is 100% success. So I'm merging this and moving on to the next PR. If the test issue remains I'll have a look at that separately, because your patch is sound regardless.