Support for coldplugging more devices #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the modprobe plugin (unsurpricingly) may cause new modules to be loaded, it makes sense to to delay the initial device node scan until we know that no mode nodes will show up within the next few microseconds.
As it turns out, not all buses in Linux will add `modalias` attributes to their devices in sysfs. One notable exception are MDIO buses. The plugin's scan routine would thus not pick them up. Fortunately, the information is always available in the device's `uevent` attribute. Therefore, default to looking for modaliases in the device's `uevent` attribute instead, falling back to `modalias` only if `uevent` is not availble (this should never happen).
|
Awesome work on this, thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, not all buses in Linux will add
modaliasattributes to their devices in sysfs. One notable exception are MDIO buses. The plugin's scan routine would thus not pick them up.Fortunately, the information is always available in the device's
ueventattribute.Therefore, default to looking for modaliases in the device's
ueventattribute instead, falling back tomodaliasonly ifueventis not availble (this should never happen).