Add github-actions #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekenta
approved these changes
Jul 14, 2022
|
@d-hrs |
|
@d-hrs |
d-hrs
suggested changes
Jul 22, 2022
d-hrs
reviewed
Jul 22, 2022
build.gradle
Outdated
| def baseVersion = "0.1.0" | ||
| def vd = versionDetails() | ||
| if (vd.commitDistance == 0 && vd.lastTag ==~ /^v[0-9]+\.[0-9]+\.[0-9]+(\.[a-zA-Z0-9]+)?/) { | ||
| baseVersion |
There was a problem hiding this comment.
do not use baseVersion
Suggested change
| baseVersion | |
| vd.lastTag.substring(1) |
There was a problem hiding this comment.
It is a correspondence to link with the release tag.
I got it.
d-hrs
suggested changes
Jul 22, 2022
build.gradle
Outdated
| description = "Bigquery output for embulk" | ||
|
|
||
| version = { | ||
| def baseVersion = "0.1.0" |
There was a problem hiding this comment.
remove baseVersion. use VersionDetails() only.
build.gradle
Outdated
| if (vd.commitDistance == 0 && vd.lastTag ==~ /^v[0-9]+\.[0-9]+\.[0-9]+(\.[a-zA-Z0-9]+)?/) { | ||
| vd.lastTag.substring(1) | ||
| } else { | ||
| "${baseVersion}.${vd.gitHash}.pre" |
There was a problem hiding this comment.
Suggested change
| "${baseVersion}.${vd.gitHash}.pre" | |
| "0.0.0.${vd.gitHash}.pre" |
or
Suggested change
| "${baseVersion}.${vd.gitHash}.pre" | |
| "${vd.lastTag.substring(1)}.${vd.gitHash}.pre" |
|
@d-hrs |
d-hrs
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added github-actions for gem push.
Target thread
Parent pull request