Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for allocations when broadcasting equations #1626

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Sep 6, 2023

See #1618

Together with #1625, this should hopefully fix the current CI issues.

Closes #1618

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@JoshuaLampert
Copy link
Member

Let's hope JuliaLang/julia#51118 will be fixed...

@ranocha
Copy link
Member Author

ranocha commented Sep 6, 2023

I hope so, too, but I'm not very optimistic, to be honest. The issue is solved in Julia v1.10 - the next stable release. Thus, I guess there is not much pressure to fix this specific issue. Of course, for us it's very important since there are much more severe issues with the current pre-release version of Julia v1.10, e.g., JuliaLang/julia#50985, JuliaLang/julia#50562

@ranocha ranocha marked this pull request as ready for review September 6, 2023 13:32
@ranocha
Copy link
Member Author

ranocha commented Sep 6, 2023

I'll merge this now since non-coverage CI passes - except the test fixed in #1625

@ranocha ranocha merged commit 81d2b70 into main Sep 6, 2023
29 of 30 checks passed
@ranocha ranocha deleted the ranocha-patch-2 branch September 6, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants