-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Downgrade.yml #105
Create Downgrade.yml #105
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 17.64% 17.64%
=======================================
Files 3 3
Lines 1423 1423
=======================================
Hits 251 251
Misses 1172 1172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There is a bug in the GitHub action that lets the action fail if a package name contains an underscore (here P4est_jll), see cjdoris/julia-downgrade-compat-action#2. |
The GitHub action is fixed now and in principle it works with the newest version. I've set the lower compat bounds to the lowest possible such that after downgrading the tests still pass. |
Looks like GitHub is doing weird stuff here, see https://devopsjournal.io/blog/2022/10/19/How-GitHub-Actions-versioning-works The |
Ok, I set the version back to v1.0.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Similar to SciML/SciMLBase.jl#553.
See https://github.com/cjdoris/julia-downgrade-compat-action and also trixi-framework/Trixi.jl#1771.