Fallback to process.cwd() for finding the cloudinary config file #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayusharma
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
👏 Very nice and thanks for taking care of it. This was creating some problems with https://github.com/trivago/prettier-plugin-sort-imports for me, and the problem seems to be fixed now.
byara
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed in this PR:
Fallback to calling
process.cwd()if theprocess.env.INIT_CWDis not available.Currently without Node setting the
INIT_CWDenv, we would not be able to have a test-runner automatically run the tests such as the vscode jest runner.E.g.