Add check for well formed runtime

triton-inference-server · Nov 8, 2023 · 5dd3ac5 · 5dd3ac5
1 parent 3d44dff
commit 5dd3ac5
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/src/backend_model.cc b/src/backend_model.cc
@@ -318,6 +318,7 @@ TritonModel::GetBackendLibraryProperties(
     }
     python_backend_based_backend_libdir = *backend_libdir;
   } else {
+    RETURN_IF_ERROR(IsRuntimeLibraryNameWellFormed(backend_libname));
     *is_python_backend_based_backend = backend_libname == kPythonFilename;
   }
 

diff --git a/src/model_config_utils.cc b/src/model_config_utils.cc
@@ -2466,4 +2466,19 @@ AssembleCPPRuntimeLibraryName(const std::string& backend_name)
 #endif
 }
 
+Status
+IsRuntimeLibraryNameWellFormed(const std::string& library_name)
+{
+  const static std::vector<std::string> excluded_strings = {"\\", "/"};
+  for (const auto& excluded_str : excluded_strings) {
+    if (library_name.find(excluded_str) != library_name.npos) {
+      return Status(
+          Status::Code::INVALID_ARG,
+          "Model configuration runtime field contains illegal sub-string '" +
+              excluded_str + "'");
+    }
+  }
+  return Status::Success;
+}
+
 }}  // namespace triton::core
diff --git a/src/model_config_utils.h b/src/model_config_utils.h
@@ -327,4 +327,10 @@ std::string InstanceConfigSignature(
 /// \return The assembled C++ runtime library name.
 std::string AssembleCPPRuntimeLibraryName(const std::string& backend_name);
 
+/// Check if runtime library name is well formed.
+/// \param library_name The library name to check.
+/// \return Success status if '\' and '/' characters are not in library name.
+/// Error status if otherwise.
+Status IsRuntimeLibraryNameWellFormed(const std::string& library_name);
+
 }}  // namespace triton::core