Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace yaml-rust with actively maintained yaml-rust2 #538

Closed
wants to merge 2 commits into from
Closed

chore: replace yaml-rust with actively maintained yaml-rust2 #538

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cc26d0
chore: replace yaml-rust with actively maintained yaml-rust2
d3rpp May 1, 2024
fe110d4
Update Cargo.toml
d3rpp May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exclude = [
]

[dependencies]
yaml-rust = { version = "0.4.5", optional = true }
yaml-rust = { version = "0.4.5", optional = true, crate = "yaml-rust2" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to documentation on this property please? I can't find it at https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it does not work. CI says: warning: unused manifest key: dependencies.yaml-rust.crate

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use one of the other PRs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#renaming-dependencies-in-cargotoml

I have made a mistake in the PR
the key this PR is attempting to use is called package not crate, my apologies.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I think we should use #544 though, it looks similar to the first PR to change to yaml2

Copy link
Author

@d3rpp d3rpp May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I think we should use #544 though, it looks similar to the first PR to change to yaml2

#544 seems like a cleaner change than this PR, so I agree that it would make sense 👍

onig = { version = "6.0", optional = true, default-features = false }
fancy-regex = { version = "0.11", optional = true }
walkdir = "2.0"
Expand Down
Loading