Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify output format for path without extension #22

Open
teohhanhui opened this issue Aug 4, 2016 · 4 comments
Open

Cannot specify output format for path without extension #22

teohhanhui opened this issue Aug 4, 2016 · 4 comments

Comments

@teohhanhui
Copy link
Contributor

e.g. https://lh4.googleusercontent.com/-P4oxiHniRcc/V1Q0kGaDVMI/AAAAAAAAS44/JV4M46DxtWc54Rjb1pv2i29CACoUmS_6QCLIB/w4000-h3000-k/

There is no way to specify the output format since the current parsing requires the input format extension before it (e.g. .jpg.webp).

@yamadapc
Copy link

yamadapc commented Oct 5, 2016

This would be fixed by using a querystring protocol for modifiers, instead of parsing the urls.

yamadapc added a commit to beijaflor-io/image-resizer that referenced this issue Oct 5, 2016
@teohhanhui
Copy link
Contributor Author

Personally, I'd love to use the query string too (it's the proper
solution). But how well does it work with CDNs? Probably okay if it's just
extra configuration.

On Thu, 6 Oct 2016, 00:59 Pedro Tacla Yamada, notifications@github.com
wrote:

This would be fixed by using a querystring protocol for modifiers, instead
of parsing the urls.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#22 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhf69xKC-h54I5x46ieWtSxRRob-vKJks5qw9eDgaJpZM4Jc06t
.

@yamadapc
Copy link

yamadapc commented Oct 5, 2016

It works fine with cloudfront afaik. There's an initial lousy impl. in my
fork.

Em qua, 5 de out de 2016 14:05, Teoh Han Hui notifications@github.com
escreveu:

Personally, I'd love to use the query string too (it's the proper
solution). But how well does it work with CDNs? Probably okay if it's just
extra configuration.

On Thu, 6 Oct 2016, 00:59 Pedro Tacla Yamada, notifications@github.com
wrote:

This would be fixed by using a querystring protocol for modifiers,
instead
of parsing the urls.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
#22 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAhf69xKC-h54I5x46ieWtSxRRob-vKJks5qw9eDgaJpZM4Jc06t

.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#22 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADvexg6jLAzjMP4MGfu2Ht3sdoUR9CJ6ks5qw9jggaJpZM4Jc06t
.

@yamadapc
Copy link

yamadapc commented Oct 5, 2016

Just to back this up a bit, I've seen other resizer CDNs, like filpicker's CDN and imgix.com do this; https://docs.imgix.com/setup/serving-images

I sort of doubt that the querystring isn't taken into account on all but only very few CDNs. Because the querystring is part of the URI, it's part of the key you really want to cache. CDNs that don't respect it seem broken to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants