Test nested fields with all storage formats in Hive connector #9286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
Sep 17, 2021
| // verify with Hive if data written by Trino | ||
| if (writer != Engine.HIVE) { | ||
| if ("AVRO".equals(format)) { | ||
| // TODO (https://github.com/trinodb/trino/issues/9285) Hive cannot read Avro nested structs written by Trino |
findepi
force-pushed
the
findepi/hive-test-struct-struct
branch
from
77918a3 to
7544d47
Compare
|
Red |
losipiuk
reviewed
Sep 17, 2021
...ng/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java
Show resolved
Hide resolved
losipiuk
reviewed
Sep 17, 2021
...ng/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java
Show resolved
Hide resolved
losipiuk
reviewed
Sep 17, 2021
...ng/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java
Show resolved
Hide resolved
maven central propagation i guess |
findepi
force-pushed
the
findepi/hive-test-struct-struct
branch
2 times, most recently
from
68e4d39 to
566e8f1
Compare
|
CI #9263 |
Note: `ensureDummyExists` method is moved, because it's nature changes from being a helper method to being a setup method.
findepi
force-pushed
the
findepi/hive-test-struct-struct
branch
from
d731266 to
2901679
Compare
This is to reduce execution time of the suite1.
findepi
force-pushed
the
findepi/hive-test-struct-struct
branch
from
2901679 to
79055ea
Compare
`singlenode` is now started once.
Suite1 is at its execution time limits. Certain `TestHiveStorageFormats` tests are not tagged as `storage_formats` because they do not need to be executed on many environments, but this makes them included in Suite1. This commits introduces new test group (`storage_formats_detailed`) and assigns it to these tests, effectively moving them from Suite1 to Suite2. It also reassigns `test*NullFormat` to the new group.
findepi
force-pushed
the
findepi/hive-test-struct-struct
branch
from
79055ea to
6dc74be
Compare
alexjo2144
approved these changes
Sep 20, 2021
|
#9263 again |
|
#9263 again cc @Praveen2112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.