Report better message when no connection from driver #6872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
Feb 11, 2021
| @@ -73,7 +73,7 @@ public Connection openConnection(ConnectorSession session) | |||
| JdbcIdentity identity = JdbcIdentity.from(session); | |||
| Properties properties = getCredentialProperties(identity); | |||
| Connection connection = driver.connect(connectionUrl.apply(identity), properties); | |||
| checkState(connection != null, "Driver returned null connection"); | |||
| checkState(connection != null, "Driver returned null connection, make sure the connection URL '%s' is valid for the driver %s", connectionUrl, driver); | |||
There was a problem hiding this comment.
I am not sure what to log here -- the connectionUrl or connectionUrl.apply(identity).
There was a problem hiding this comment.
connectionUrl is a Function. So not a very loggable thing.
There was a problem hiding this comment.
You're right. I was too quick.
There was a problem hiding this comment.
I will chat with @kokosing why we need a function here.
There was a problem hiding this comment.
I think it is no longer used. And could be removed. I haven't found any usages of it.
There was a problem hiding this comment.
Thanks @kokosing for checking! will simplify
ppalucha
approved these changes
Feb 11, 2021
The connectionUrl never depends on identity.
findepi
force-pushed
the
findepi/report-better-message-when-no-connection-from-driver-85c2f7
branch
from
edaf901 to
34a88dd
Compare
|
AC |
losipiuk
approved these changes
Feb 22, 2021
findepi
deleted the
findepi/report-better-message-when-no-connection-from-driver-85c2f7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.