Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer ImmutableMap to Map #6761

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Prefer ImmutableMap to Map #6761

merged 1 commit into from
Feb 2, 2021

Conversation

ssheikin
Copy link
Contributor

@ssheikin ssheikin commented Jan 29, 2021 •
edited
Loading

ConnectorMetadata#getColumnHandles is immutable

found during #6745

@cla-bot cla-bot bot added the cla-signed label Jan 29, 2021
@ssheikin
Prefer ImmutableMap to Map
d074a19 
ConnectorMetadata#getColumnHandles,
ConnectorMetadata#listTableColumns
are immutable
@ssheikin ssheikin force-pushed the ssheikin/9/immutable_column_handles branch from 0379709 to d074a19 Compare February 1, 2021 13:13
@ssheikin
Copy link
Contributor Author

ssheikin commented Feb 1, 2021

@Praveen2112 @kokosing CA, PA

@ssheikin
Copy link
Contributor Author

ssheikin commented Feb 2, 2021

@Praveen2112 @kokosing @findepi
multinode-hive-caching failed with

2021-02-01T16:37:41.009Z	WARN	TestRun-diagnostic	io.trino.tests.product.launcher.cli.SuiteRun	Test execution is not finished yet, a deadlock or hang is suspected. Thread dump will follow.
2021-02-01T16:37:41.556Z	WARN	TestRun-diagnostic	io.trino.tests.product.launcher.cli.SuiteRun	Full Thread Dump:

https://github.com/trinodb/trino/runs/1806778279?check_suite_focus=true
And it seems unrelated to this pr.
Could you please help to identify Flaky test issue?

@kokosing
Copy link
Member

kokosing commented Feb 2, 2021

@ssheikin Created one just for you: #6799

@kokosing
Copy link
Member

kokosing commented Feb 2, 2021

FYI:

kokosing@m16:~/presto$ git grep 'toImmutableMap(' | wc -l
202
kokosing@m16:~/presto$ git grep 'toMap(' | wc -l
95

@kokosing kokosing merged commit c498038 into trinodb:master Feb 2, 2021
@kokosing
Copy link
Member

kokosing commented Feb 2, 2021

Merged, thanks!

@ssheikin
Copy link
Contributor Author

ssheikin commented Feb 2, 2021

FYI:

kokosing@m16:~/presto$ git grep 'toImmutableMap(' | wc -l
202
kokosing@m16:~/presto$ git grep 'toMap(' | wc -l
95

This is a good point to improve.

@ssheikin ssheikin mentioned this pull request Feb 2, 2021
Open
@ssheikin ssheikin deleted the ssheikin/9/immutable_column_handles branch February 15, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing kokosing left review comments

@Praveen2112 Praveen2112 Praveen2112 approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssheikin @kokosing @Praveen2112