Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2481
Have manually tested against Sybase ASE:
show schemas, select count(1) with filters and without, select * without filters and with some where filters
things that might stop this being merged?
todo: should this be specific to Sybase ASE? I've not tried on Sybase IQ yet
Some tests:
presto> select * from sybase.dbo.monTables where size between 100 and 105 and description like '%lust%';
tableid | columns | parameters | indicators | size | tablename | description | language
---------+---------+------------+------------+------+--------------+----------------------------------------------------+----------
61 | 19 | 0 | 4 | 104 | monCIPCMesh | Cluster IPC message statistics for the entire mesh | en_US
65 | 7 | 0 | 4 | 100 | monCIPCLinks | Cluster IPC message link status | en_US
(2 rows)
Query 20200301_225813_00002_uksth, FINISHED, 1 node
http://localhost:8080/ui/query.html?20200301_225813_00002_uksth
Splits: 17 total, 17 done (100.00%)
CPU Time: 0.0s total, 171 rows/s, 0B/s, 27% active
Per Node: 0.0 parallelism, 4 rows/s, 0B/s
Parallelism: 0.0
Peak Memory: 0B
0:01 [6 rows, 0B] [4 rows/s, 0B/s]
presto> show schemas from sybase;
Schema
dbo
dtm_tm_role
guest
ha_role
hadr_admin_role_gp
information_schema
js_admin_role
js_client_role
js_user_role
keycustodian_role
messaging_role
mon_role
navigator_role
oper_role
probe
public
replication_maint_role_gp
replication_role
sa_role
sa_serverprivs_role
sso_role
sybase_ts_role
usedb_user
webservices_role
(24 rows)
Query 20200301_230017_00003_uksth, FINISHED, 1 node
http://localhost:8080/ui/query.html?20200301_230017_00003_uksth
Splits: 19 total, 19 done (100.00%)
CPU Time: 0.1s total, 311 rows/s, 5.19KB/s, 23% active
Per Node: 0.2 parallelism, 57 rows/s, 971B/s
Parallelism: 0.2
Peak Memory: 0B
0:00 [24 rows, 409B] [57 rows/s, 971B/s]
presto> use sybase.dbo;
USE
presto:dbo> show tables;
Table
etshostresourceutilizationview
etsservicememoryview
etsservicestatisticsview
ijdbc_function_escapes
jdbc_function_escapes
monbucketpool
moncachedobject
moncachedprocedures
moncachedstatement
moncachepool
moncipc
moncipcendpoints
moncipclinks
moncipcmesh
monclmobjectactivity
monclustercachemanager
moncmsfailover
mondatacache
mondbrecovery
mondbrecoverylrtypes
mondeadlock
mondeviceio
mondevicesegmentio
mondevicesegmentusage
mondevicespaceusage
monengine
monerrorlog
monfailoverrecovery
monhadrmembers
monimrscacheactivity
monimrsgctasks
monimrspartitionactivity
moninmemorystorage
moniocontroller
monioqueue
monlatchfreeindex
monlicense
monlocks
monlocktimeout
monlogicalcluster
monlogicalclusteraction
monlogicalclusterinstance
monlogicalclusterroute
monmemoryusage
monnetworkio
monnvcache
monopendatabases
monopenobjectactivity
monopenpartitionactivity
monpcibridge
Query 20200301_230030_00006_uksth, FINISHED, 1 node
http://localhost:8080/ui/query.html?20200301_230030_00006_uksth
Splits: 19 total, 19 done (100.00%)
CPU Time: 0.1s total, 1.44K rows/s, 40.6KB/s, 39% active
Per Node: 0.1 parallelism, 196 rows/s, 5.54KB/s
Parallelism: 0.1
Peak Memory: 0B
0:01 [122 rows, 3.45KB] [196 rows/s, 5.54KB/s]
presto:dbo> select count(1) from sybase.dbo.monTables where size > 1;
_col0
102
(1 row)
Query 20200301_230632_00008_uksth, FINISHED, 1 node
http://localhost:8080/ui/query.html?20200301_230632_00008_uksth
Splits: 18 total, 18 done (100.00%)
CPU Time: 0.0s total, 3.4K rows/s, 0B/s, 19% active
Per Node: 0.0 parallelism, 136 rows/s, 0B/s
Parallelism: 0.0
Peak Memory: 0B
0:01 [102 rows, 0B] [136 rows/s, 0B/s]
presto:dbo> select count(1) from sybase.dbo.monTables;
_col0
102
(1 row)
Query 20200301_230637_00009_uksth, FINISHED, 1 node
http://localhost:8080/ui/query.html?20200301_230637_00009_uksth
Splits: 18 total, 18 done (100.00%)
CPU Time: 0.0s total, 6.8K rows/s, 0B/s, 23% active
Per Node: 0.0 parallelism, 320 rows/s, 0B/s
Parallelism: 0.0
Peak Memory: 0B
0:00 [102 rows, 0B] [320 rows/s, 0B/s]
presto:dbo> select count(1) from sybase.dbo.monTables where size > 100;
_col0
(1 row)
Query 20200301_230917_00010_uksth, FINISHED, 1 node
http://localhost:8080/ui/query.html?20200301_230917_00010_uksth
Splits: 18 total, 18 done (100.00%)
CPU Time: 0.0s total, 4.73K rows/s, 0B/s, 18% active
Per Node: 0.0 parallelism, 198 rows/s, 0B/s
Parallelism: 0.0
Peak Memory: 0B
0:00 [71 rows, 0B] [198 rows/s, 0B/s]