Use CassandraQueryWaitStrategy in CassandraServer #19928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
commented
Nov 28, 2023
| return dockerContainer.getMappedPort(PORT); | ||
| } | ||
|
|
||
| private static void checkConnectivity(CassandraSession session) |
There was a problem hiding this comment.
This method is replaced with CassandraQueryWaitStrategy
ebyhr
commented
Nov 28, 2023
| import static org.testcontainers.utility.MountableFile.forHostPath; | ||
|
|
||
| public class CassandraServer | ||
| implements Closeable | ||
| { | ||
| private static final Logger log = Logger.get(CassandraServer.class); | ||
|
|
||
| private static final int PORT = 9142; |
There was a problem hiding this comment.
CassandraContainer expects 9042 as the default port.
ebyhr
force-pushed
the
ebi/cassandra-flaky-test
branch
from
3545c2c to
c68a64d
Compare
wendigo
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19926
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.