Run BigQuery Arrow and FTE tests in a separated profile #19767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/bigquery-fte
branch
2 times, most recently
from
af86500 to
c440e47
Compare
hashhar
approved these changes
Nov 16, 2023
|
|
|
merging those two makes sense. Let me check if BigQueryInstanceCleaner has been leaving cruft behind, 50m seems like a lot. |
|
@hashhar It seems we separated arrow profile for adding additional JVM options. Do we still want to merge those profile? |
|
We can as long as we have at least one profile with default JVM. |
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/bigquery-fte
branch
from
c440e47 to
3354e7c
Compare
wendigo
approved these changes
Nov 16, 2023
ebyhr
force-pushed
the
ebi/bigquery-fte
branch
from
3354e7c to
96561fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate profile for BigQuery FTE tests to fix timeout issue on CI.
e.g. https://github.com/trinodb/trino/actions/runs/6882906460/job/18722457149
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.