Change latest connector test to smoke test in MariaDB #19765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
reviewed
Nov 16, 2023
There was a problem hiding this comment.
FWIW in other connectors like Mongo, SingleStore we use SmokeTest for the latest version and full ConnectorTest for the older versions.
You can also convert TestMySqlLegacyConnectorTest.java to a smoketest but will need to copy testNativeQueryWithClause, testAlterTableRenameColumnToLongName, testRenameColumnName and testRenameColumn.
Also, update the docker image versions.
ebyhr
force-pushed
the
ebi/mariadb-test
branch
from
c8321c9 to
1d97ec0
Compare
ebyhr
changed the title
hashhar
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the docker image version to remove support for old versions https://endoflife.date/mariadb
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.