Do not require all sinks to be finished in FileSystemExchange #19736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not enforced by engine that each created sink will be finished. Some tasks may be abandoned as not required for computing query result and siks for those tasks will not be finished.
losipiuk
requested review from
findepi,
arhimondr,
wweiss-starburst and
sopel39
findepi
approved these changes
Nov 14, 2023
| @@ -183,7 +183,6 @@ public void allRequiredSinksFinished() | |||
| return; | |||
| } | |||
| verify(noMoreSinks, "noMoreSinks is expected to be set"); | |||
| verify(finishedSinks.keySet().containsAll(allSinks), "all sinks are expected to be finished"); | |||
There was a problem hiding this comment.
do we need to finish/close the sinks that weren't finished yet?
can there be a resource leak we if we do not so?
There was a problem hiding this comment.
I also though about it. Theoretically yeah - but not the case for exchange implementation we have right now. So I would not extend SPI just yet - we can add the method if we see it is needed for some upcoming exchange impl.
There was a problem hiding this comment.
can there be a resource leak we if we do not so?
maybe not a leak, but memory could be stalled for a longer time then needed. I would close them if we can
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not enforced by engine that each created sink will be finished. Some tasks may be abandoned as not required for computing query result and siks for those tasks will not be finished.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.