Add support for guessing Decimal128 in MongoDB #18722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/mongodb-guess-decimal128
branch
from
9ef23aa to
43ef9fd
Compare
ebyhr
force-pushed
the
ebi/mongodb-guess-decimal128
branch
from
43ef9fd to
1fb3bbd
Compare
ebyhr
force-pushed
the
ebi/mongodb-guess-decimal128
branch
from
1fb3bbd to
beb92ca
Compare
|
We already have this type listed as being mapped in the Trino docs... was that previously incorrect? |
|
The connector tries to guess the column definition for the 1st access when the table was created in MongoDB side. So, Decimal128 type was supported when the table was created in Trino. This PR allows mapping Decimal128 as decimal when guessing the definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) Release notes are required, with the following suggested text: