Fix Delta INSERT when schema OR table location ends with two slashes #17980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
changed the title
github-actions
bot
added
delta-lake
Configure bucket used in `TestIcebergS3AndGlueMetastoreTest` same way as in other `BaseS3AndGlueMetastoreTest` subclasses. Makes it easier to run tests locally. This also changes `TestIcebergGlueCatalogConnectorSmokeTest` for consistency.
This may be needed when working with MinIO containers where bucket names can be reused. This is not needed when working with real S3 where bucket names are unique. Also, it's unclear whether this is a safe operation when tests execute in parallel.
The `String.contains`-based inclusions/exclusions doesn't allow distinguishing between hypothetical cases like "trailing_slash" and "two_trailing_slashes". This also simplifies generated test locations for schemas. Previously the schema name was formatted twice into the location string.
Remove constructor which doesn't construct the table. Since it was randomizing the name, it couldn't even be used for dropping existing table.
Use try with resources to ensure that test tables are dropped even if an assertion fails.
findepi
force-pushed
the
findepi/delta-trailing-slashes
branch
from
ea91f94 to
29963d1
Compare
ebyhr
approved these changes
Jun 21, 2023
Comment on lines
164
to
165
| // Hive normalizes double slash | ||
| .replaceAll("(?<!(s3:))/+", "/"); |
There was a problem hiding this comment.
nit: double slash → multiple slash?
|
Build is 🔴 |
findinpath
approved these changes
Jun 21, 2023
findepi
force-pushed
the
findepi/delta-trailing-slashes
branch
from
29963d1 to
ab96466
Compare
|
fixed iceberg test failures, but didn't fix delta yet |
findepi
changed the title
findepi
force-pushed
the
findepi/delta-trailing-slashes
branch
from
ab96466 to
b6c9cf0
Compare
|
CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #17958
For #17966, but does not fix it fully.