Revert "Remove usages of Hadoop Path for Hive LocationService" #17947
Conversation
|
Why revert? What would it take to fix the issue, instead? cc @electrum |
|
Hadoop Since that commit we no longer normalize table location during CREATE TABLE, so Trino can easily create Hive tables with double slashes in the location, but these are not supported yet: #17804 (comment). We should restore normalization to fix the problem and unblock the release. |
ebyhr
force-pushed
the
ebi/hive-double-slash
branch
from
ea5c8b4 to
2934f4d
Compare
| { | ||
| try { | ||
| return Location.of(location); | ||
| Location.of(location); // Calling just for validation |
There was a problem hiding this comment.
testTableLocationTopOfTheBucket doesn't pass without this line.
ebyhr
force-pushed
the
ebi/hive-double-slash
branch
from
2934f4d to
784b2c3
Compare
| @@ -452,8 +452,9 @@ public static Location getTableDefaultLocation(Database database, HdfsContext co | |||
| throw new TrinoException(HIVE_DATABASE_LOCATION_ERROR, format("Database '%s' location is not a directory: %s", schemaName, databasePath)); | |||
| } | |||
| } | |||
| Location.of(databasePath.toString()); // Calling just for validation | |||
There was a problem hiding this comment.
testCreateSchemaWithIncorrectLocation doesn't pass without this line.
findepi
force-pushed
the
ebi/hive-double-slash
branch
from
784b2c3 to
2aa4d9b
Compare
|
#17958 may yield similar benfits (restore normalization), with fewer lines changed. |
Description
Revert 8bd9f75.
Relates to #17804 (comment)
Release notes
(x) This is not user-visible or docs only and no release notes are required.