Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for SET PATH #17658

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented May 27, 2023

Description

Trying to document the command that clearly exists .. looking at the parser setup and such. Not clear yet what it is supposed to do and how it works.

The test codebase does not have any useful examples.

Additional context and related issues

Fixed #17657

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label May 27, 2023
@github-actions github-actions bot added the docs label May 27, 2023
@mosabua mosabua requested a review from martint May 27, 2023 00:17
docs/src/main/sphinx/sql/set-path.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/set-path.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/set-path.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/set-path.rst Outdated Show resolved Hide resolved
@mosabua mosabua force-pushed the mm/set-path branch 2 times, most recently from 75ec9df to 300f592 Compare May 29, 2023 15:59
@mosabua mosabua force-pushed the mm/set-path branch 2 times, most recently from 865eb36 to 66bb126 Compare May 29, 2023 17:18
@mosabua mosabua requested a review from kasiafi May 29, 2023 17:29
@mosabua
Copy link
Member Author

mosabua commented May 30, 2023

I think this is good to go now @martint and @kasiafi .

docs/src/main/sphinx/sql/set-path.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/set-path.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/set-path.rst Show resolved Hide resolved
docs/src/main/sphinx/sql/set-path.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/set-path.rst Outdated Show resolved Hide resolved
@mosabua mosabua force-pushed the mm/set-path branch 2 times, most recently from 1406540 to 685bdff Compare June 8, 2023 21:31
@mosabua
Copy link
Member Author

mosabua commented Jun 8, 2023

Had to rebase against the new markdown toctree file but all else is same.

@mosabua mosabua merged commit 6129d35 into trinodb:master Jun 8, 2023
@mosabua mosabua deleted the mm/set-path branch June 8, 2023 21:33
@github-actions github-actions bot added this to the 420 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Document SET PATH
3 participants