-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refer ${project.version} instead of hardcoded version in trino-test-jdbc-compatibility-old-driver pom.xml #17642
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankush Chatterjee.
|
Have emailed signed CLA. |
CLA is now signed |
@cla-bot check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankush Chatterjee.
|
The cla-bot has been summoned, and re-checked this pull request! |
Could you fix the commit author? Also, please shorten the commit title. |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankush Chatterjee.
|
1 similar comment
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankush Chatterjee.
|
e0ca42c
to
a0673f9
Compare
Refer ${project.version} instead of hardcoded version for dep.presto-jdbc-under-test default value.
4a79583
to
647f81f
Compare
Have rebased the change. @ebyhr can this be merged? |
Description
The default value of
dep.presto-jdbc-under-test
is hardcoded to the current version. Instead${project.version}
can be used.Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: