Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE YET] Require Java 21 to run Trino #17520

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE YET] Require Java 21 to run Trino #17520

wants to merge 1 commit into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented May 16, 2023 •
edited
Loading

Require Java 21 in the runtime to run Trino.

Fixes #17017

@cla-bot cla-bot bot added the cla-signed label May 16, 2023
@wendigo
Copy link
Contributor Author

wendigo commented May 16, 2023

Alluxio is broken but it's ok:

Caused by: java.lang.NumberFormatException: For input string: "21-ea"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:661)
	at java.base/java.lang.Integer.parseInt(Integer.java:777)
	at alluxio.util.CommonUtils.parseMajorVersion(CommonUtils.java:885)
	at alluxio.util.CommonUtils.<clinit>(CommonUtils.java:84)
	... 16 more

@wendigo wendigo force-pushed the serafin/jdk21-tests branch from 3f086f5 to 06686d2 Compare May 17, 2023 08:20
@github-actions github-actions bot added hive Hive connector tests:hive labels May 17, 2023
@wendigo wendigo force-pushed the serafin/jdk21-tests branch from 06686d2 to ee46b58 Compare June 7, 2023 13:28
@github-actions github-actions bot added the hudi Hudi connector label Jun 7, 2023
@wendigo wendigo force-pushed the serafin/jdk21-tests branch from ee46b58 to 8674a96 Compare June 7, 2023 19:28
@wendigo wendigo force-pushed the serafin/jdk21-tests branch 4 times, most recently from 3f4850c to 4caa97a Compare June 22, 2023 09:19
@wendigo wendigo force-pushed the serafin/jdk21-tests branch 3 times, most recently from b1cf19a to 18765ab Compare June 25, 2023 08:38
@wendigo wendigo force-pushed the serafin/jdk21-tests branch 2 times, most recently from 649120b to 61ac48e Compare July 6, 2023 18:34
@wendigo wendigo force-pushed the serafin/jdk21-tests branch 2 times, most recently from 53679f8 to 0ee02ae Compare July 13, 2023 12:34
@wendigo wendigo force-pushed the serafin/jdk21-tests branch 4 times, most recently from 49105e5 to ce41b70 Compare August 29, 2023 11:23
@wendigo wendigo changed the title [JDK 21] Compatibility testing Require Java 21 to run Trino Aug 29, 2023
wendigo
wendigo commented Aug 29, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -56,8 +57,7 @@ jobs:
fail-fast: false
matrix:
java-version:
- 17
- 20
- 21-ea
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update to 21 when GA is available

wendigo
wendigo commented Aug 29, 2023
View reviewed changes
.github/actions/setup/action.yml Outdated
@@ -3,7 +3,7 @@ description: "Verify checked out commits and setup Java"
inputs:
java-version:
description: "Java version to setup"
default: 17
default: 21-ea
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update to 21 when GA is available

wendigo
wendigo commented Aug 29, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -634,7 +633,7 @@ jobs:
- uses: ./.github/actions/setup
with:
cache: restore
java-version: ${{ matrix.jdk != '' && matrix.jdk || '17' }}
java-version: ${{ matrix.jdk != '' && matrix.jdk || '21-ea' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update to 21 when GA is available

wendigo
wendigo commented Aug 29, 2023
View reviewed changes
core/docker/build.sh
@@ -13,7 +13,7 @@ Builds the Trino Docker image
EOF
}

ARCHITECTURES=(amd64 arm64 ppc64le)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Restore when JDK 21 ppc64 images are available

wendigo
wendigo commented Aug 29, 2023
View reviewed changes
core/trino-server-rpm/src/test/java/io/trino/server/rpm/ServerIT.java Outdated
return new Object[][]{
{rpmHostPath, "17"},
{rpmHostPath, "19"}};
{rpmHostPath, "openjdk:21-ea-oraclelinux7", "21"}};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: use temurin JDK 21 image when available

@wendigo wendigo changed the title Require Java 21 to run Trino [DO NOT MERGE YET] Require Java 21 to run Trino Aug 29, 2023
@nineinchnick nineinchnick mentioned this pull request Sep 5, 2023
Merged
@wendigo wendigo force-pushed the serafin/jdk21-tests branch 2 times, most recently from 643d732 to d33deab Compare September 14, 2023 06:47
@wendigo
Copy link
Contributor Author

wendigo commented Sep 14, 2023

@nineinchnick works like a charm 🪄

@wendigo wendigo force-pushed the serafin/jdk21-tests branch from d33deab to 9388a65 Compare September 30, 2023 17:03
@wendigo wendigo force-pushed the serafin/jdk21-tests branch from 9388a65 to b94ccf5 Compare September 30, 2023 17:05
@wendigo wendigo mentioned this pull request Oct 12, 2023
Closed
@wendigo wendigo closed this Oct 12, 2023
@wendigo wendigo deleted the serafin/jdk21-tests branch October 12, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum left review comments

Assignees
No one assigned
Labels
cla-signed hive Hive connector hudi Hudi connector
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JDK 21] Build and run Trino on JDK 21
2 participants
@wendigo @electrum