Add Spanner connector #16724

taher-cldcvr · 2023-03-25T11:20:21Z

Description

Release notes

(x) Release notes are required, with the following suggested text:

# General
* Add Spanner connector. ({issue}`13053`)

cla-bot · 2023-03-25T11:20:23Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

ebyhr

Please add a documentation and tests (connector test, type mapping test, product test and etc). You can refer to #8323

taher-cldcvr · 2023-03-26T04:46:32Z

@ebyhr sure, thank you for the reference. I will keep enhancing the PR

…y keys,not null fields, timestamp field options etc.

cla-bot · 2023-03-27T13:20:46Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-03-27T13:25:17Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

ebyhr · 2023-03-28T01:34:29Z

Could you change to draft PR if it's not ready for review?

ebyhr · 2023-03-28T01:30:34Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

@@ -0,0 +1,660 @@
+package io.trino.plugin.spanner;


The license header is missing.

ebyhr · 2023-03-28T01:31:30Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+            case Types.CHAR:
+            case Types.VARCHAR:
+            case Types.NVARCHAR:
+            case Types.LONGVARCHAR:
+            case Types.LONGNVARCHAR:


All conditions are really needed?

ebyhr · 2023-03-28T01:31:35Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+            case Types.BINARY:
+            case Types.VARBINARY:
+            case Types.LONGVARBINARY:


All conditions are really needed?

ebyhr · 2023-03-28T01:35:37Z

plugin/trino-spanner/src/test/java/TestSpannerDataTypes.java

+import io.trino.testing.MaterializedResult;
+import org.testng.annotations.Test;
+
+public class TestSpannerDataTypes


Rename to TestSpannerTypeMapping

ebyhr · 2023-03-28T01:35:43Z

plugin/trino-spanner/src/test/java/TestSpannerDataTypes.java

+        MaterializedResult execute = queryRunner.execute("select * from spanner.default.dtest");
+        System.out.println(execute);
+
+    }


Please cover all types in this test.

ebyhr · 2023-03-28T01:48:28Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerTableProperties.java

+    @Inject
+    public SpannerTableProperties()
+    {
+        System.out.println("CALLED TABLE PROPERTIES ");


ebyhr · 2023-03-28T01:49:46Z

plugin/trino-spanner/src/test/java/SpannerSqlQueryRunner.java

+        MaterializedResult drop = queryRunner.execute("DROP TABLE spanner.default.dept");
+        System.out.println(drop);
+
+        System.out.println("DONE");


Please remove System.out.println.

ebyhr · 2023-03-28T01:51:37Z

pom.xml

@@ -196,6 +196,7 @@
        <module>testing/trino-testing-resources</module>
        <module>testing/trino-testing-services</module>
        <module>testing/trino-tests</module>
+        <module>plugin/trino-spanner</module>


Please update core/trino-server/src/main/provisio/trino.xml as well.

ebyhr · 2023-03-28T01:54:06Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+                        DATE,
+                        dateReadFunctionUsingLocalDate(),
+                        spannerDateWriteFunctionUsingLocalDate()));
+            case Types.TIMESTAMP:


I would recommend removing support for TIMESTAMP in this PR. We can add the type later.

ebyhr · 2023-03-28T01:54:29Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+                            return timestamp.toInstant().toEpochMilli() * 1000;
+                        },
+                        (statement, index, value) -> statement.setTimestamp(index, new java.sql.Timestamp(value / 1000))));
+            case Types.BOOLEAN:


Move before Types.SMALLINT.

taher-cldcvr · 2023-03-28T04:17:56Z

@ebyhr changed to draft as not ready for review yet

…modes as insert and upsert

cla-bot · 2023-04-14T10:50:44Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-04-14T11:00:10Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

taher-cldcvr · 2023-04-14T11:02:00Z

@ebyhr Spanner JDBC does not allow upserts when inserting duplicate records with the same key. So i changed spanner sink from JdbcSink to write via Spanner Mutations API which can do upserts. So right now spanner reads everything over JDBC but writes are made via Spanner API. What is the best practise her? Should reads also change to Spanner API? or we can allow reads and writes to be different API's as in this case

taher-cldcvr · 2023-04-14T11:03:56Z

@ebyhr Another reason why I changed from JDBC sink to Spanner mutations API-based sink is that randomly after creating a table JDBC would throw an error that the table is not ready in the spanner. That was automatically taken care of by the spanner mutations api. For this see https://cloud.google.com/spanner/docs/information-schema#columns Spanner state

chenjian2664

Nice work!

chenjian2664 · 2023-04-26T08:44:04Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+                resultSet.getString("TABLE_NAME"));
+    }
+
+    public static void sleep()


What's the usage about this method?

Nah just random testing will remove that

chenjian2664 · 2023-04-26T08:44:44Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+        int jdbcType = typeHandle.getJdbcType();
+        String jdbcTypeName = typeHandle.getJdbcTypeName()
+                .orElseThrow(() -> new TrinoException(JDBC_ERROR, "Type name is missing: " + typeHandle));
+        System.out.println("Column mapping for type " + typeHandle);


Remove system.out.println

chenjian2664 · 2023-04-26T08:45:33Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+        switch (jdbcType) {
+            case Types.BOOLEAN:
+                return Optional.of(StandardColumnMappings.booleanColumnMapping());
+            case Types.SMALLINT:


How about add a type mapping test? you can refer TestIgniteTypeMapping as a example

chenjian2664 · 2023-04-26T08:46:41Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+    @Override
+    public Collection<String> listSchemas(Connection connection)
+    {
+        Set<String> schemas = new HashSet<>(Collections.singleton(DEFAULT_SCHEMA));


User ImmutableSet.Builder

chenjian2664 · 2023-04-26T08:47:38Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+        Set<String> schemas = new HashSet<>(Collections.singleton(DEFAULT_SCHEMA));
+        try (ResultSet resultSet = connection.getMetaData().getSchemas(null, null)) {
+            while (resultSet.next()) {
+                schemas.add(resultSet.getString(1));


How about use resultSet.getString(name)

chenjian2664 · 2023-04-26T08:50:08Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+    }
+
+    @Override
+    public List<JdbcColumnHandle> getColumns(ConnectorSession session, JdbcTableHandle tableHandle)


Why override?

chenjian2664 · 2023-04-26T08:56:44Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+    {
+    }
+
+    @Override


Why override?

chenjian2664 · 2023-04-26T08:58:49Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+    public SpannerClient(BaseJdbcConfig config, SpannerConfig spannerConfig, JdbcStatisticsConfig statisticsConfig, ConnectionFactory connectionFactory, QueryBuilder queryBuilder, TypeManager typeManager, IdentifierMapping identifierMapping, RemoteQueryModifier queryModifier)
+    {
+        super("`", connectionFactory, queryBuilder, config.getJdbcTypesMappedToVarchar(), identifierMapping, queryModifier, true);
+        this.config = spannerConfig;


requireNonNull(spannerConfig, "spannerConfig is null")

chenjian2664 · 2023-04-26T09:00:09Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+            throws SQLException
+    {
+        String schema = resultSet.getString("TABLE_SCHEM");
+        if (schema != null && schema.equals("")) {


Strings.emptyToNull

chenjian2664 · 2023-04-26T09:01:18Z

plugin/trino-spanner/src/main/java/io/trino/plugin/spanner/SpannerClient.java

+    }
+
+    @Override
+    public TableStatistics getTableStatistics(ConnectorSession session, JdbcTableHandle handle)


Same, why override?

chenjian2664 · 2023-04-26T09:05:31Z

@taher-cldcvr If the write side is much more complicated than the read part, maybe we can support read for Spanner connector first cc @ebyhr

taher-cldcvr · 2023-04-26T10:49:58Z

@taher-cldcvr If the write side is much more complicated than the read part, maybe we can support read for Spanner connector first cc @ebyhr

It is not complicated as it is already implemented and works well. I want to review and need help testing the writing side thoroughly

taher-cldcvr · 2023-04-26T10:50:31Z

Thank you @chenjian2664 for the review. I will address the comments and add more test cases.

cla-bot · 2023-06-06T07:23:13Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2023-06-15T07:28:19Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

taher-cldcvr · 2023-06-15T07:29:45Z

Need help with test case @ebyhr , @chenjian2664
6555aa8

I am getting the following error when testing for test type mapping
`2023-06-15T02:26:00.023-0500 INFO dispatcher-query-3 io.trino.event.QueryMonitor TIMELINE: Query 20230615_072559_00000_tysvf :: FINISHED :: elapsed 708ms :: planning 194ms :: waiting 214ms :: scheduling 468ms :: running 38ms :: finishing 8ms :: begin 2023-06-15T01:25:59.299-06:00 :: end 2023-06-15T01:26:00.007-06:00
2023-06-15T02:26:00.183-0500 INFO dispatcher-query-4 io.trino.event.QueryMonitor TIMELINE: Query 20230615_072600_00001_tysvf :: FINISHED :: elapsed 109ms :: planning 48ms :: waiting 9ms :: scheduling 45ms :: running 15ms :: finishing 1ms :: begin 2023-06-15T01:26:00.060-06:00 :: end 2023-06-15T01:26:00.169-06:00
2023-06-15T02:26:00.196-0500 INFO main io.trino.testng.services.FlakyTestRetryAnalyzer FlakyTestRetryAnalyzer not enabled: CONTINUOUS_INTEGRATION environment is not detected or system property 'io.trino.testng.services.FlakyTestRetryAnalyzer.enabled' is not set to 'true' (actual: )

org.assertj.core.error.MultipleAssertionsError:
The following assertion failed:

[Rows for query [SELECT * FROM test_boolean]]
Expecting actual:

to contain exactly in any order:
[(true, false, null, 1)]
but could not find the following elements:
(true, false, null, 1)

at org.assertj.core.error.AssertionErrorCreator.multipleAssertionsError(AssertionErrorCreator.java:106)
at org.assertj.core.api.AbstractAssert.multipleAssertionsError(AbstractAssert.java:979)
at org.assertj.core.api.AbstractAssert.satisfiesForProxy(AbstractAssert.java:875)
at org.assertj.core.api.AbstractAssert.satisfies(AbstractAssert.java:862)
at io.trino.sql.query.QueryAssertions$QueryAssert.matches(QueryAssertions.java:384)
at io.trino.testing.datatype.SqlDataTypeTest.verifySelect(SqlDataTypeTest.java:119)
at io.trino.testing.datatype.SqlDataTypeTest.execute(SqlDataTypeTest.java:91)
at io.trino.testing.datatype.SqlDataTypeTest.execute(SqlDataTypeTest.java:84)
at io.trino.plugin.spanner.TestSpannerDataTypesMapping.testBoolean(TestSpannerDataTypesMapping.java:52)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
at org.testng.TestRunner.privateRun(TestRunner.java:756)
at org.testng.TestRunner.run(TestRunner.java:610)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:387)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:382)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
at org.testng.SuiteRunner.run(SuiteRunner.java:289)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1293)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1218)
at org.testng.TestNG.runSuites(TestNG.java:1133)
at org.testng.TestNG.run(TestNG.java:1104)
at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:66)
at com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:109)`

Dont understand what i did wrong here

cla-bot · 2023-10-20T07:38:01Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

taher-cldcvr · 2023-10-20T07:39:16Z

Need help with test case @ebyhr , @chenjian2664 6555aa8

I am getting the following error when testing for test type mapping `2023-06-15T02:26:00.023-0500 INFO dispatcher-query-3 io.trino.event.QueryMonitor TIMELINE: Query 20230615_072559_00000_tysvf :: FINISHED :: elapsed 708ms :: planning 194ms :: waiting 214ms :: scheduling 468ms :: running 38ms :: finishing 8ms :: begin 2023-06-15T01:25:59.299-06:00 :: end 2023-06-15T01:26:00.007-06:00 2023-06-15T02:26:00.183-0500 INFO dispatcher-query-4 io.trino.event.QueryMonitor TIMELINE: Query 20230615_072600_00001_tysvf :: FINISHED :: elapsed 109ms :: planning 48ms :: waiting 9ms :: scheduling 45ms :: running 15ms :: finishing 1ms :: begin 2023-06-15T01:26:00.060-06:00 :: end 2023-06-15T01:26:00.169-06:00 2023-06-15T02:26:00.196-0500 INFO main io.trino.testng.services.FlakyTestRetryAnalyzer FlakyTestRetryAnalyzer not enabled: CONTINUOUS_INTEGRATION environment is not detected or system property 'io.trino.testng.services.FlakyTestRetryAnalyzer.enabled' is not set to 'true' (actual: )

org.assertj.core.error.MultipleAssertionsError: The following assertion failed:

[Rows for query [SELECT * FROM test_boolean]]
Expecting actual:

to contain exactly in any order: [(true, false, null, 1)] but could not find the following elements: (true, false, null, 1)
at org.assertj.core.error.AssertionErrorCreator.multipleAssertionsError(AssertionErrorCreator.java:106)
at org.assertj.core.api.AbstractAssert.multipleAssertionsError(AbstractAssert.java:979)
at org.assertj.core.api.AbstractAssert.satisfiesForProxy(AbstractAssert.java:875)
at org.assertj.core.api.AbstractAssert.satisfies(AbstractAssert.java:862)
at io.trino.sql.query.QueryAssertions$QueryAssert.matches(QueryAssertions.java:384)
at io.trino.testing.datatype.SqlDataTypeTest.verifySelect(SqlDataTypeTest.java:119)
at io.trino.testing.datatype.SqlDataTypeTest.execute(SqlDataTypeTest.java:91)
at io.trino.testing.datatype.SqlDataTypeTest.execute(SqlDataTypeTest.java:84)
at io.trino.plugin.spanner.TestSpannerDataTypesMapping.testBoolean(TestSpannerDataTypesMapping.java:52)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
at org.testng.TestRunner.privateRun(TestRunner.java:756)
at org.testng.TestRunner.run(TestRunner.java:610)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:387)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:382)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
at org.testng.SuiteRunner.run(SuiteRunner.java:289)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1293)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1218)
at org.testng.TestNG.runSuites(TestNG.java:1133)
at org.testng.TestNG.run(TestNG.java:1104)
at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:66)
at com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:109)`
Dont understand what i did wrong here

@findepi @chenjian2664 @ebyhr @ragnard I cannot understand what is going wrong with this test case. Please can you guys help me

taher-cldcvr · 2024-01-15T06:09:25Z

Need help with test case @ebyhr , @chenjian2664 6555aa8
I am getting the following error when testing for test type mapping `2023-06-15T02:26:00.023-0500 INFO dispatcher-query-3 io.trino.event.QueryMonitor TIMELINE: Query 20230615_072559_00000_tysvf :: FINISHED :: elapsed 708ms :: planning 194ms :: waiting 214ms :: scheduling 468ms :: running 38ms :: finishing 8ms :: begin 2023-06-15T01:25:59.299-06:00 :: end 2023-06-15T01:26:00.007-06:00 2023-06-15T02:26:00.183-0500 INFO dispatcher-query-4 io.trino.event.QueryMonitor TIMELINE: Query 20230615_072600_00001_tysvf :: FINISHED :: elapsed 109ms :: planning 48ms :: waiting 9ms :: scheduling 45ms :: running 15ms :: finishing 1ms :: begin 2023-06-15T01:26:00.060-06:00 :: end 2023-06-15T01:26:00.169-06:00 2023-06-15T02:26:00.196-0500 INFO main io.trino.testng.services.FlakyTestRetryAnalyzer FlakyTestRetryAnalyzer not enabled: CONTINUOUS_INTEGRATION environment is not detected or system property 'io.trino.testng.services.FlakyTestRetryAnalyzer.enabled' is not set to 'true' (actual: )
org.assertj.core.error.MultipleAssertionsError: The following assertion failed:

[Rows for query [SELECT * FROM test_boolean]]
Expecting actual:

to contain exactly in any order: [(true, false, null, 1)] but could not find the following elements: (true, false, null, 1)
at org.assertj.core.error.AssertionErrorCreator.multipleAssertionsError(AssertionErrorCreator.java:106)
at org.assertj.core.api.AbstractAssert.multipleAssertionsError(AbstractAssert.java:979)
at org.assertj.core.api.AbstractAssert.satisfiesForProxy(AbstractAssert.java:875)
at org.assertj.core.api.AbstractAssert.satisfies(AbstractAssert.java:862)
at io.trino.sql.query.QueryAssertions$QueryAssert.matches(QueryAssertions.java:384)
at io.trino.testing.datatype.SqlDataTypeTest.verifySelect(SqlDataTypeTest.java:119)
at io.trino.testing.datatype.SqlDataTypeTest.execute(SqlDataTypeTest.java:91)
at io.trino.testing.datatype.SqlDataTypeTest.execute(SqlDataTypeTest.java:84)
at io.trino.plugin.spanner.TestSpannerDataTypesMapping.testBoolean(TestSpannerDataTypesMapping.java:52)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
at org.testng.TestRunner.privateRun(TestRunner.java:756)
at org.testng.TestRunner.run(TestRunner.java:610)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:387)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:382)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
at org.testng.SuiteRunner.run(SuiteRunner.java:289)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1293)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1218)
at org.testng.TestNG.runSuites(TestNG.java:1133)
at org.testng.TestNG.run(TestNG.java:1104)
at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:66)
at com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:109)`
Dont understand what i did wrong here
@findepi @chenjian2664 @ebyhr @ragnard I cannot understand what is going wrong with this test case. Please can you guys help me

@ebyhr @findepi can you guys help me understand what I am doing wrong here? I feel like this is a very simple assertion error of expecting elements in list. I cannot figure out what needs to change.

Added Spanner connector

a34eb43

ebyhr reviewed Mar 25, 2023

View reviewed changes

ebyhr assigned taher-cldcvr Mar 27, 2023

Added more datatypes parsing. Added create table features like primar…

5deb3f2

…y keys,not null fields, timestamp field options etc.

Removed useless file

8b1045e

ebyhr reviewed Mar 28, 2023

View reviewed changes

taher-cldcvr marked this pull request as draft March 28, 2023 04:17

Added spanner sink which uses spanner Mutations. Added spanner write …

14cf842

…modes as insert and upsert

Added licenses and changed sink

dbe61fc

chenjian2664 reviewed Apr 26, 2023

View reviewed changes

Added spanner transactions

c8e5f5f

Added dtype test case for spanner

6555aa8

findepi changed the title ~~Added Spanner connector~~ Add Spanner connector Jun 15, 2023

Try fix test case for Spanner Datatype mapping

7097ff0

Add Spanner connector #16724

Are you sure you want to change the base?

Add Spanner connector #16724

Conversation

taher-cldcvr commented Mar 25, 2023 • edited by ebyhr Loading

Description

Release notes

cla-bot bot commented Mar 25, 2023

ebyhr left a comment • edited Loading

Choose a reason for hiding this comment

taher-cldcvr commented Mar 26, 2023

cla-bot bot commented Mar 27, 2023

cla-bot bot commented Mar 27, 2023

ebyhr commented Mar 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

taher-cldcvr commented Mar 28, 2023

cla-bot bot commented Apr 14, 2023

cla-bot bot commented Apr 14, 2023

taher-cldcvr commented Apr 14, 2023

taher-cldcvr commented Apr 14, 2023 • edited Loading

chenjian2664 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chenjian2664 commented Apr 26, 2023

taher-cldcvr commented Apr 26, 2023

taher-cldcvr commented Apr 26, 2023

cla-bot bot commented Jun 6, 2023

cla-bot bot commented Jun 15, 2023

taher-cldcvr commented Jun 15, 2023 • edited Loading

cla-bot bot commented Oct 20, 2023

taher-cldcvr commented Oct 20, 2023

taher-cldcvr commented Jan 15, 2024

taher-cldcvr commented Mar 25, 2023 •

edited by ebyhr

Loading

ebyhr left a comment •

edited

Loading

taher-cldcvr commented Apr 14, 2023 •

edited

Loading

taher-cldcvr commented Jun 15, 2023 •

edited

Loading