Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce CachingHiveMetastoreBuilder #15767

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Introduce CachingHiveMetastoreBuilder #15767

merged 1 commit into from
Jan 22, 2023

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Jan 18, 2023

  • NO RELEASE NOTES *

@cla-bot cla-bot bot added the cla-signed label Jan 18, 2023
@sopel39
Copy link
Member Author

sopel39 commented Jan 18, 2023

This is preparation for caching stats by default

@findepi findepi requested review from losipiuk, electrum and dain January 19, 2023 08:23
@findepi findepi dismissed their stale review January 20, 2023 10:44

addressed

@sopel39 sopel39 requested a review from findepi January 20, 2023 12:47
findepi
findepi approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

please add @CanIgnoreReturnValue to builder configuration methods

@sopel39 sopel39 merged commit bc5d2e1 into trinodb:master Jan 22, 2023
@sopel39 sopel39 deleted the ks/cache_builder branch January 22, 2023 18:42
@github-actions github-actions bot added this to the 406 milestone Jan 22, 2023
@colebow colebow mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@losipiuk losipiuk Awaiting requested review from losipiuk

@electrum electrum Awaiting requested review from electrum

@dain dain Awaiting requested review from dain

Assignees
No one assigned
Labels
cla-signed
Milestone
406
Development

Successfully merging this pull request may close these issues.
4 participants
@sopel39 @findepi @losipiuk @raunaqmorarka