Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PushDownDereferenceThroughProject to not fire on non-identity source #15676

Closed
wants to merge 1 commit into from

Conversation

weiatwork
Copy link
Contributor

Description

Fixes #15659

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jan 11, 2023
@weiatwork weiatwork requested review from martint and phd3 January 11, 2023 22:08
@weiatwork
Copy link
Contributor Author

@martint I understand that #15680 will fix the issue from the perspective of not producing problematic symbol mappings. But I think the fix of this PR is still needed, as a local fix and safeguard to the specific rule

@github-actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 20, 2023
@bitsondatadev
Copy link
Member

@weiatwork looks like #15659 was fixed by #15680. I am closing this for now. Feel free to reopen if there is another issue that is left unresolved. Thank you!

@weiatwork
Copy link
Contributor Author

Hi Brian, thanks for the housekeeping. I understand that the original issue was fixed via a different PR. I was waiting on @martint to take a look if the change in this PR is still necessary, as a safeguard

@weiatwork weiatwork reopened this Feb 21, 2023
@bitsondatadev
Copy link
Member

Ah cool, I'll reach out to him.

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 17, 2024
@mosabua
Copy link
Member

mosabua commented Jan 17, 2024

@martint I think this can be closed now since you just merged a related PR. See links in the issue.

@github-actions github-actions bot removed the stale label Jan 18, 2024
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 12, 2024
Copy link

github-actions bot commented Mar 5, 2024

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Security issue with access control: column masking gets lost when querying only nested field
3 participants