Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check rollback_to_snapshot accuracy when it does not do any changes #15655

Conversation

findinpath
Copy link
Contributor

Description

When performing rollback_to_snapshot procedure calls with the latest snapshot of the table as parameter, the operation used to fail in Trino 403 while it depended on Iceberg 1.0.0:

Caused by: java.lang.IllegalStateException: Cannot commit transaction: last operation has not committed
    at org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkState(Preconditions.java:502)
    at org.apache.iceberg.BaseTransaction.commitTransaction(BaseTransaction.java:252)
    at org.apache.iceberg.SnapshotManager.commit(SnapshotManager.java:158)
    at io.trino.plugin.iceberg.RollbackToSnapshotProcedure.rollbackToSnapshot(RollbackToSnapshotProcedure.java:80)

With Iceberg 1.1.0 the problem was fixed in apache/iceberg#5536 .

This extra check is a regression test for future Iceberg library releases.

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Jan 10, 2023
@findinpath findinpath self-assigned this Jan 10, 2023
@findepi findepi added test no-release-notes This pull request does not require release notes entry ready to merge labels Jan 10, 2023
@ebyhr ebyhr merged commit 6f660ce into trinodb:master Jan 12, 2023
@github-actions github-actions bot added this to the 406 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry test
Development

Successfully merging this pull request may close these issues.

3 participants