Fix failure when subquery contains time travel #15607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
approved these changes
Jan 5, 2023
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
| { | ||
| String tableName = "test_subquery_versioned" + randomNameSuffix(); | ||
|
|
||
| assertUpdate("CREATE TABLE " + tableName + " AS SELECT 1 id", 1); |
There was a problem hiding this comment.
nit : Can we use TestTable here
There was a problem hiding this comment.
I would keep as-is for the consistency in this class.
findepi
approved these changes
Jan 5, 2023
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
Implement QueryPeriod.shallowEquals method to fix failure in logical planner.
ebyhr
force-pushed
the
ebi/iceberg-time-travel-in-subquery
branch
from
aabd8bf to
effebb5
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix failure when the subquery contains time travel.
I added a test to only Iceberg because tests in the planner fails early due to unsupported time travel in tpch connector.
Release notes
(x) Release notes are required, with the following suggested text: