Add procedure argument check for NULL value #15508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krvikash
added
the
no-release-notes
krvikash
force-pushed
the
check-procedure-argument-for-null
branch
from
2764719 to
f45efda
Compare
alexjo2144
reviewed
Dec 22, 2022
core/trino-main/src/main/java/io/trino/connector/system/KillQueryProcedure.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
check-procedure-argument-for-null
branch
from
f45efda to
a572d55
Compare
ebyhr
reviewed
Dec 22, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/procedure/DropStatsProcedure.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/procedure/RegisterPartitionProcedure.java
Outdated
Show resolved
Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/procedure/UnregisterPartitionProcedure.java
Outdated
Show resolved
Hide resolved
...ino-product-tests/src/main/java/io/trino/tests/product/hive/TestHivePartitionProcedures.java
Outdated
Show resolved
Hide resolved
...ino-product-tests/src/main/java/io/trino/tests/product/hive/TestHivePartitionProcedures.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/connector/system/runtime/TestKillQuery.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/connector/system/runtime/TestKillQuery.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/connector/system/runtime/TestKillQuery.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
check-procedure-argument-for-null
branch
from
a572d55 to
e426d99
Compare
|
@alexjo2144, @ebyhr addressed review comments. |
krvikash
force-pushed
the
check-procedure-argument-for-null
branch
from
e426d99 to
426bc80
Compare
ebyhr
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add procedure argument check for NULL value. Added test cases for respective procedure class.
Release notes
(X) This is not user-visible or docs only and no release notes are required.