Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for connector catalog examples-1 #15465

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

sheajamba
Copy link
Member

@sheajamba sheajamba commented Dec 19, 2022

Description

Clarifies example names in connector docs for the TPCH, TPCDS, Thrift, Google Sheets, and Atop connectors.

Continuation of: #13964

Additional context and related issues

Other connector PRs:

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot
Copy link

cla-bot bot commented Dec 19, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sheajamba sheajamba changed the title Connector docs examples 1 Update docs for connector catalog examples-1 Dec 19, 2022
@findepi
Copy link
Member

findepi commented Dec 19, 2022

@sheajamba there apparently was a force push to master (per #15365 (comment)), so your PR appears as if containing some unrelated commits.
Can you please rebase to remove them?

@ebyhr ebyhr force-pushed the connector-docs-examples-1 branch from dfcc8fa to e6129f0 Compare December 19, 2022 21:40
@cla-bot cla-bot bot added the cla-signed label Dec 19, 2022
@sheajamba sheajamba force-pushed the connector-docs-examples-1 branch from e6129f0 to 51e93c4 Compare December 29, 2022 16:43
@martint martint merged commit 25e9ed3 into trinodb:master Jan 17, 2023
@github-actions github-actions bot added this to the 406 milestone Jan 17, 2023
@mosabua
Copy link
Member

mosabua commented Jan 18, 2023

Could you also merge the related others @martint - see https://github.com/trinodb/trino/pulls/sheajamba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants