Recreate thrift client during alternate calls #15462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrzypo987
force-pushed
the
skrzypo/138-recreate-thrift-client-during-alternate-calls
branch
from
ef4f676 to
31f20df
Compare
findepi
reviewed
Dec 19, 2022
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Outdated
Show resolved
Hide resolved
skrzypo987
force-pushed
the
skrzypo/138-recreate-thrift-client-during-alternate-calls
branch
from
31f20df to
85155ba
Compare
skrzypo987
force-pushed
the
skrzypo/138-recreate-thrift-client-during-alternate-calls
branch
2 times, most recently
from
4fda268 to
b915728
Compare
skrzypo987
force-pushed
the
skrzypo/138-recreate-thrift-client-during-alternate-calls
branch
from
b915728 to
3b0936f
Compare
Praveen2112
reviewed
Dec 20, 2022
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Show resolved
Hide resolved
findepi
reviewed
Dec 20, 2022
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Show resolved
Hide resolved
skrzypo987
force-pushed
the
skrzypo/138-recreate-thrift-client-during-alternate-calls
branch
from
3b0936f to
2f22d3c
Compare
Co-authored-by: Dain Sundstrom <dain@iq80.com>
findepi
force-pushed
the
skrzypo/138-recreate-thrift-client-during-alternate-calls
branch
from
2f22d3c to
3b4c24e
Compare
findepi
approved these changes
Dec 20, 2022
Praveen2112
approved these changes
Dec 20, 2022
...rino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastoreClient.java
Show resolved
Hide resolved
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An alternative approach to #15433
The connection is being closed and created again after an alternative call ends up with an exception.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: