Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document raw_query table function in Elasticsearch connector #15442

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Dec 16, 2022

Description

Provide proper documentation and example usage of the raw_query table function in the Elasticsearch connector documentation

Additional context and related issues

Resolves #13007

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Dec 16, 2022
@jhlodin jhlodin force-pushed the jl/elastic-raw-query branch 2 times, most recently from cc31fff to e553d57 Compare December 16, 2022 17:23
@@ -379,35 +380,6 @@ Elasticsearch Trino Supports
(all others) (unsupported) (unsupported)
============= ============= =============

Pass-through queries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is completely equivalent in terms of what kind of statements we can pass through ... as such we might not be able to delete the docs just yet ... maybe we should leave it until the feature is removed as well .. wdyt @martint and @kasiafi ?

Copy link
Contributor Author

@jhlodin jhlodin Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the recommendation to deprecate this content in the linked issue, but I have the same question. If there are still use cases we want to support for legacy query passthrough then we should keep that content, but likely pare it down and maybe make it a sub-header under raw_query

@github-actions github-actions bot added the docs label Dec 16, 2022
@jhlodin jhlodin force-pushed the jl/elastic-raw-query branch from e553d57 to b87dbd0 Compare December 16, 2022 22:19
@ebyhr ebyhr merged commit 7103f36 into trinodb:master Dec 19, 2022
@github-actions github-actions bot added this to the 404 milestone Dec 19, 2022
@jhlodin jhlodin deleted the jl/elastic-raw-query branch December 19, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Document raw_query table function for Elasticsearch connector
3 participants