Fix error in Iceberg predicate pushdown to Parquet files #15408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Dec 15, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
alexjo2144
force-pushed
the
iceberg/parquet-nested-predicate-pushdown
branch
from
d008516 to
49923d7
Compare
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
alexjo2144
force-pushed
the
iceberg/parquet-nested-predicate-pushdown
branch
4 times, most recently
from
f25f034 to
d6b26b5
Compare
ebyhr
approved these changes
Dec 15, 2022
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
The Paruqet reader does not support pushdown on fields of a Row type. The checks in `IcebergPageSourceProvider#getParquetTupleDomain` used to prevent this, but they stopped working when dereference pushdown was implemented. If a row field had the same name as a top level column this would have resulted in a correctness issue.
alexjo2144
force-pushed
the
iceberg/parquet-nested-predicate-pushdown
branch
from
d6b26b5 to
bd01541
Compare
|
Thanks all, cleaned those little things up |
This was referenced Dec 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Paruqet reader does not support pushdown on fields of a Row type. The checks in
IcebergPageSourceProvider#getParquetTupleDomainused to prevent this, but they stopped working when dereference pushdown was implemented.If a row field had the same name as a top level column this would have resulted in a correctness issue.
Additional context and related issues
Deref/projection pushdown was implemented in: #8129
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: