Add refresh interval for DB resource group manager #15389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Dec 14, 2022
There was a problem hiding this comment.
Please shorten the commit title. https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
...ers/src/main/java/io/trino/plugin/resourcegroups/db/DbResourceGroupConfigurationManager.java
Outdated
Show resolved
Hide resolved
...roup-managers/src/test/java/io/trino/plugin/resourcegroups/db/TestDbResourceGroupConfig.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jaeho.yoo/add_frequency_resource_group
branch
2 times, most recently
from
f555644 to
2abdaed
Compare
Shortened it :) |
ebyhr
reviewed
Dec 14, 2022
...ce-group-managers/src/main/java/io/trino/plugin/resourcegroups/db/DbResourceGroupConfig.java
Show resolved
Hide resolved
...ce-group-managers/src/main/java/io/trino/plugin/resourcegroups/db/DbResourceGroupConfig.java
Outdated
Show resolved
Hide resolved
Chaho12
force-pushed
the
feature/jaeho.yoo/add_frequency_resource_group
branch
from
28ba257 to
b89d00b
Compare
ebyhr
approved these changes
Dec 15, 2022
Chaho12
force-pushed
the
feature/jaeho.yoo/add_frequency_resource_group
branch
from
b89d00b to
e3d9b37
Compare
ebyhr
force-pushed
the
feature/jaeho.yoo/add_frequency_resource_group
branch
from
d371efc to
0a9ace6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the configuration is reloaded from the database every second, with
max-refresh-intervalof 1 hr (default).In some cases, users might want to change refresh interval up to milliseconds unit depending on their system. So, I added refresh interval property
Tested with setting refresh interval as 10 sec.
I also removed
refreshFailuresprivate variable as it is not used at all, and there is no need to use it.Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text: