Update MySQL JDBC driver to 8.0.29 #15345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative to #12692, let's see what tests fail. |
|
Same failures as in #14917, negative date related tests. I guess we'll need to add validation on Trino side to disallow negative values until the driver is fixed. I'll see how we can report a bug to the driver - I just left a comment at mysql/mysql-connector-j@60553fd#r88985720 in past. |
hashhar
force-pushed
the
hashhar/mysql-8.0.29
branch
from
dd5cf43 to
d55ca6b
Compare
|
Got it working, added a test to verify driver bug too so that once we update to working driver we can get notified. I've started the process to file the bug to MySQL - waiting to hear back. |
ebyhr
approved these changes
Dec 9, 2022
plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlLegacyConnectorTest.java
Outdated
Show resolved
Hide resolved
|
@ebyhr Addressed comments as fixups. It's using |
This fixes an issue where system.query function failed if the query contained a WITH clause because the older MySQL JDBC drivers did not return metadata for queries containing WITH clause.
This test will start failing once a MySQL driver with the bug resolved is being used and can then be removed as well as the code changes from the previous commit partially reverted.
hashhar
force-pushed
the
hashhar/mysql-8.0.29
branch
from
9c00cef to
af15cfc
Compare
ebyhr
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update MySQL JDBC driver to 8.0.29
Fixes #15332 Closes #12692
Additional context and related issues
Update MySQL JDBC driver to 8.0.29
Release notes
(x) Release notes are required, with the following suggested text: