Test SET PATH support by clients #15327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Dec 7, 2022
client/trino-client/src/main/java/io/trino/client/StatementClientV1.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/pass-client-capabilities
branch
from
3791adc to
f254427
Compare
If you're not filling the PR template, please remove it from the PR description so that it's obvious to the reader there there isn't any information to look for. |
|
Client capabilities, as the name suggests, are an attribute of a client. |
wendigo
force-pushed
the
serafin/pass-client-capabilities
branch
from
f254427 to
1c13c61
Compare
|
@kokosing test added |
findepi
reviewed
Dec 8, 2022
client/trino-client/src/main/java/io/trino/client/ClientCapabilities.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/pass-client-capabilities
branch
2 times, most recently
from
150d723 to
16d45ec
Compare
wendigo
changed the title
wendigo
changed the title
findepi
reviewed
Dec 9, 2022
client/trino-client/src/main/java/io/trino/client/StatementClientV1.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/TestingTrinoClient.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/tests/TestServer.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/pass-client-capabilities
branch
from
16d45ec to
6f00515
Compare
findepi
approved these changes
Dec 9, 2022
wendigo
force-pushed
the
serafin/pass-client-capabilities
branch
from
6f00515 to
4a49a98
Compare
wendigo
force-pushed
the
serafin/pass-client-capabilities
branch
from
4a49a98 to
7aa1b26
Compare
findepi
approved these changes
Dec 9, 2022
kokosing
approved these changes
Dec 12, 2022
kokosing
added
the
no-release-notes
|
Thanks! Merged. |
|
Looks like this is something I should've done 4 years ago as an intern. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: