Improve heuristic of using dictionary in project and filter #15266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When last dictionary was not effective but incoming dictionary size is not bigger than the block size, enable dictionary processing. Earlier this logic would apply only to the next dictionary through the existing `lastDictionaryUsageCount >= lastInputDictionary.getPositionCount()` condition. This change makes the heuristic more consistent by applying the same logic to the incoming dictionary page as well.
sopel39
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When last dictionary was not effective but incoming dictionary size is not bigger than the block size, enable dictionary processing. Earlier this logic would apply only to the next dictionary through the existing
lastDictionaryUsageCount >= lastInputDictionary.getPositionCount()condition. This change makes the heuristic more consistent by applying the same logic to the incoming dictionary page as well.Additional context and related issues
Minor improvement, not significant enough to RN.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: