Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store query id and fix schema already exists error when creating a schema in Hive #15177

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 24, 2022

Description

This is similar change to #13242
Fixes #15174

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Hive
* Store query ID when creating a new schema. ({issue}`15174`)
* Fix incorrect `schema already exists` error caused by a client timeout when
  creating a new schema. ({issue}`15174`)

Copy link
Member

@homar homar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but would it be possible to add a test?

@findinpath
Copy link
Contributor

Looks good but would it be possible to add a test?

We'll probably need to have a way to plug-in the metastore so that we can control what it does when creating tables (e.g. : call 2 x times createDatabase)

#14779 (comment)

@ebyhr ebyhr merged commit d12e9b3 into master Nov 24, 2022
@ebyhr ebyhr deleted the ebi/hive-create-database-wrong-error branch November 24, 2022 22:15
@ebyhr ebyhr mentioned this pull request Nov 24, 2022
@github-actions github-actions bot added this to the 404 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants