Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error in set-milestone workflow #15110

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix syntax error in set-milestone workflow #15110

merged 1 commit into from
Nov 18, 2022

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Nov 18, 2022

No description provided.

@hashhar hashhar added the no-release-notes This pull request does not require release notes entry label Nov 18, 2022
@cla-bot cla-bot bot added the cla-signed label Nov 18, 2022
@hashhar hashhar requested a review from a team November 18, 2022 17:55
@ebyhr
Copy link
Member

ebyhr commented Nov 18, 2022

Let me merge since the job keeps failing. Thanks for sending this PR.

@ebyhr ebyhr merged commit acc2886 into trinodb:master Nov 18, 2022
@ebyhr
Copy link
Member

ebyhr commented Nov 18, 2022

The job is still failing on master. https://github.com/trinodb/trino/actions/runs/3500540195/jobs/5863313308

Error: Unhandled error: HttpError: Validation Failed: {"resource":"Milestone","code":"already_exists","field":"title"}

@hashhar
Copy link
Member Author

hashhar commented Nov 19, 2022

I'll revert to known working state and try to test on a fork somehow.

@hashhar hashhar deleted the hashhar/fix-set-milestone branch November 19, 2022 09:07
@hashhar hashhar added this to the 404 milestone Nov 19, 2022
@hashhar
Copy link
Member Author

hashhar commented Nov 19, 2022

revert commit - #15118

@colebow colebow mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@raunaqmorarka raunaqmorarka raunaqmorarka approved these changes

@nineinchnick nineinchnick nineinchnick approved these changes

@martint martint Awaiting requested review from martint

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
405
Development

Successfully merging this pull request may close these issues.
4 participants
@hashhar @ebyhr @nineinchnick @raunaqmorarka