Call semanticException method as a format method in several places #15051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
approved these changes
Nov 16, 2022
|
Kudu tests timed out |
|
@ksobolew Please report the flakiness of kudu as github issue. |
|
It's actually this one: #14487 |
|
The release is now in progress. I will merge once the release is complete. Please ping me if I forget. |
|
Ping :) |
|
No release notes. |
|
@ksobolew Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
semanticExceptionfactory method is a format method - it takes a format string and format arguments - so it shoule be called as one. A future PR will enforce that using Error Prone, this PR collects fixes for the less trivial cases that need to be converted.Non-technical explanation
Better code quality.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: