Load value once after expiration in EvictableCache #14644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change, when value was time-expired, the new token inserted for the cache loading was immediately discarded due to expiration event. Co-authored-by: Anton Tanasenko <atg.sleepless@gmail.com>
findepi
force-pushed
the
findepi/evictable-load-once
branch
from
e3dfb67 to
834d934
Compare
losipiuk
approved these changes
Oct 14, 2022
Does or does not? |
Does not. But I change mind after offline conversation. It actually does. |
|
|
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, when value was time-expired, the new token inserted for the cache loading was immediately discarded due to expiration event.
Fixes #14545
Alternative to #14476